redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

dm log: clean up bit little endian bitops 

Using __test_and_{set,clear}_bit_le() with ignoring its return value
can be replaced with __{set,clear}_bit_le().

This also removes unnecessary casts.

Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Signed-off-by: Alasdair G Kergon <agk@redhat.com>
hifive-unleashed-5.1
Akinobu Mita 2011-08-02 12:32:01 +01:00 committed by Alasdair G Kergon
parent 936688d7eb
commit c8f543e078
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/md/dm-log.c
View File

@ -257,20 +257,20 @@ struct log_c {
*/
static inline int log_test_bit(uint32_t *bs, unsigned bit)
{
return test_bit_le(bit, (unsigned long *) bs) ? 1 : 0;
return test_bit_le(bit, bs) ? 1 : 0;
}
static inline void log_set_bit(struct log_c *l,
uint32_t *bs, unsigned bit)
{
__test_and_set_bit_le(bit, (unsigned long *) bs);
__set_bit_le(bit, bs);
l->touched_cleaned = 1;
}
static inline void log_clear_bit(struct log_c *l,
uint32_t *bs, unsigned bit)
{
__test_and_clear_bit_le(bit, (unsigned long *) bs);
__clear_bit_le(bit, bs);
l->touched_dirtied = 1;
}
@ -745,8 +745,7 @@ static int core_get_resync_work(struct dm_dirty_log *log, region_t *region)
return 0;
do {
*region = find_next_zero_bit_le(
(unsigned long *) lc->sync_bits,
*region = find_next_zero_bit_le(lc->sync_bits,
lc->region_count,
lc->sync_search);
lc->sync_search = *region + 1;