redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

staging: rtl8712/: Using comparison to true is error prone

Browse source 
clear below issues reported by checkpatch.pl:

CHECK: Using comparison to true is error prone
CHECK: Comparison to NULL should be written "!oldest"

Signed-off-by: John Oldman <john.oldman@polehill.co.uk>
Link: https://lore.kernel.org/r/20200710113113.1648-1-john.oldman@polehill.co.uk
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
John Oldman 2020-07-10 12:31:13 +01:00 committed by Greg Kroah-Hartman
parent a3232e64b4
commit cb22ab20c9
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
drivers/staging/rtl8712/rtl871x_mlme.c
View file

@ -264,13 +264,13 @@ struct wlan_network *r8712_get_oldest_wlan_network(
phead = &scanned_queue->queue; phead = &scanned_queue->queue;
plist = phead->next; plist = phead->next;
while (1) { while (1) {
if (end_of_queue_search(phead, plist) == true) if (end_of_queue_search(phead, plist))
break; break;
pwlan = container_of(plist, struct wlan_network, list); pwlan = container_of(plist, struct wlan_network, list);
if (pwlan->fixed != true) { if (!pwlan->fixed) {
if (oldest == NULL || if (!oldest ||
time_after((unsigned long)oldest->last_scanned, time_after((unsigned long)oldest->last_scanned,
(unsigned long)pwlan->last_scanned)) (unsigned long)pwlan->last_scanned))
oldest = pwlan; oldest = pwlan;
} }
plist = plist->next; plist = plist->next;