redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

r8169: disable detection of bogus xid's 308/388

Browse source 
Several years ago these two entries have been added, but it's not clear
why. There's no trace that there has ever been such a chip version, and
not even the r8101 vendor driver knows these id's. So let's disable
detection, and if nobody complains remove them completely later.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Heiner Kallweit 2021-02-10 22:45:51 +01:00 committed by David S. Miller
parent 9c2db446ea
commit cb456fce0b
1 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
drivers/net/ethernet/realtek/r8169_main.c
View file

@ -2036,9 +2036,12 @@ static enum mac_version rtl8169_get_mac_version(u16 xid, bool gmii)
{ 0x7c8, 0x348, RTL_GIGA_MAC_VER_09 },
{ 0x7c8, 0x248, RTL_GIGA_MAC_VER_09 },
{ 0x7c8, 0x340, RTL_GIGA_MAC_VER_16 },
/* FIXME: where did these entries come from ? -- FR */
{ 0xfc8, 0x388, RTL_GIGA_MAC_VER_13 },
{ 0xfc8, 0x308, RTL_GIGA_MAC_VER_13 },
/* FIXME: where did these entries come from ? -- FR
* Not even r8101 vendor driver knows these id's,
* so let's disable detection for now. -- HK
* { 0xfc8, 0x388, RTL_GIGA_MAC_VER_13 },
* { 0xfc8, 0x308, RTL_GIGA_MAC_VER_13 },
*/
/* 8110 family. */
{ 0xfc8, 0x980, RTL_GIGA_MAC_VER_06 },