redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

drivers: net: davinci_mdio: fix return value check in davinci_mdio_probe() 

In case of error, the function devm_ioremap() returns NULL pointer not
ERR_PTR(). The IS_ERR() test in the return value check should be
replaced with NULL test.

Fixes: 03f66f0675 ("net: ethernet: ti: davinci_mdio: use devm_ioremap()")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
hifive-unleashed-5.2
Wei Yongjun 2019-05-03 11:18:59 +00:00 committed by David S. Miller
parent ca96534630
commit cc0d47b8ee
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/net/ethernet/ti/davinci_mdio.c
View File

@ -398,8 +398,8 @@ static int davinci_mdio_probe(struct platform_device *pdev)
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
data->regs = devm_ioremap(dev, res->start, resource_size(res));
if (IS_ERR(data->regs))
return PTR_ERR(data->regs);
if (!data->regs)
return -ENOMEM;
davinci_mdio_init_clk(data);