redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

[PATCH] lib/string.c cleanup: remove pointless register keyword 

Removes a few pointless register keywords.  register is merely a compiler
hint that access to the variable should be optimized, but gcc (3.3.6 in my
case) generates the exact same code with and without the keyword, and even
if gcc did something different with register present I think it is doubtful
we would want to optimize access to these variables - especially since this
is generic library code and there are supposed to be optimized versions in
asm/ for anything that really matters speed wise.

(akpm: iirc, keyword register is a gcc no-op unless using -O0)

Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
hifive-unleashed-5.1
Jesper Juhl 2005-10-30 15:02:12 -08:00 committed by Linus Torvalds
parent 51a0f0f658
commit cc75fb71c0
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/string.c
View File

@ -219,7 +219,7 @@ EXPORT_SYMBOL(strlcat);
#undef strcmp
int strcmp(const char *cs, const char *ct)
{
register signed char __res;
signed char __res;
while (1) {
if ((__res = *cs - *ct++) != 0 || !*cs++)
@ -239,7 +239,7 @@ EXPORT_SYMBOL(strcmp);
*/
int strncmp(const char *cs, const char *ct, size_t count)
{
register signed char __res = 0;
signed char __res = 0;
while (count) {
if ((__res = *cs - *ct++) != 0 || !*cs++)