redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

scsi: qla1280: Fix printk regression 

Since Linus Torvalds reinstated KERN_CONT in commit 4bcc595ccd ("printk:
reinstate KERN_CONT for printing continuation lines") in 2015, the qla1280
SCSI driver printed a rather ugly and screen real estate wasting multi-line
per device status glibberish during boot. Fix this by adding KERN_CONT as
needed.

Tested on my Sgi Octane: https://youtu.be/Lfqe1SYR2jk

Link: https://lore.kernel.org/r/20201210.223944.388095546873159172.rene@exactcode.com
Signed-off-by: René Rebe <rene@exactcode.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
master
René Rebe 2020-12-10 22:39:44 +01:00 committed by Martin K. Petersen
parent d3ba622db8
commit cd9df0c216
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/scsi/qla1280.c
View File

@ -3906,18 +3906,18 @@ qla1280_get_target_parameters(struct scsi_qla_host *ha,
printk(KERN_INFO "scsi(%li:%d:%d:%d):", ha->host_no, bus, target, lun);
if (mb[3] != 0) {
printk(" Sync: period %d, offset %d",
printk(KERN_CONT " Sync: period %d, offset %d",
(mb[3] & 0xff), (mb[3] >> 8));
if (mb[2] & BIT_13)
printk(", Wide");
printk(KERN_CONT ", Wide");
if ((mb[2] & BIT_5) && ((mb[6] >> 8) & 0xff) >= 2)
printk(", DT");
printk(KERN_CONT ", DT");
} else
printk(" Async");
printk(KERN_CONT " Async");
if (device->simple_tags)
printk(", Tagged queuing: depth %d", device->queue_depth);
printk("\n");
printk(KERN_CONT ", Tagged queuing: depth %d", device->queue_depth);
printk(KERN_CONT "\n");
}