drm/i915: preserve other DP_TEST_SINK bits.
Sink crc was implemented based on dp 1.1 spec that had all TEST_SINK bits reserved reading all 0s. But when reviewing my latest changes on sink crc Todd warned me that on new specs we have other valid bits on this reg that we might want to preserve. Cc: Todd Previte <tprevite@gmail.com> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> Reviewed-by: Todd Previte <tprevite@gmail.com> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
This commit is contained in:
parent
da09654d77
commit
ce31d9f4fc
|
@ -3817,8 +3817,9 @@ int intel_dp_sink_crc(struct intel_dp *intel_dp, u8 *crc)
|
||||||
if (!(buf & DP_TEST_CRC_SUPPORTED))
|
if (!(buf & DP_TEST_CRC_SUPPORTED))
|
||||||
return -ENOTTY;
|
return -ENOTTY;
|
||||||
|
|
||||||
|
drm_dp_dpcd_readb(&intel_dp->aux, DP_TEST_SINK, &buf);
|
||||||
if (drm_dp_dpcd_writeb(&intel_dp->aux, DP_TEST_SINK,
|
if (drm_dp_dpcd_writeb(&intel_dp->aux, DP_TEST_SINK,
|
||||||
DP_TEST_SINK_START) < 0)
|
buf | DP_TEST_SINK_START) < 0)
|
||||||
return -EIO;
|
return -EIO;
|
||||||
|
|
||||||
drm_dp_dpcd_readb(&intel_dp->aux, DP_TEST_SINK_MISC, &buf);
|
drm_dp_dpcd_readb(&intel_dp->aux, DP_TEST_SINK_MISC, &buf);
|
||||||
|
@ -3837,7 +3838,10 @@ int intel_dp_sink_crc(struct intel_dp *intel_dp, u8 *crc)
|
||||||
if (drm_dp_dpcd_read(&intel_dp->aux, DP_TEST_CRC_R_CR, crc, 6) < 0)
|
if (drm_dp_dpcd_read(&intel_dp->aux, DP_TEST_CRC_R_CR, crc, 6) < 0)
|
||||||
return -EIO;
|
return -EIO;
|
||||||
|
|
||||||
drm_dp_dpcd_writeb(&intel_dp->aux, DP_TEST_SINK, 0);
|
drm_dp_dpcd_readb(&intel_dp->aux, DP_TEST_SINK, &buf);
|
||||||
|
drm_dp_dpcd_writeb(&intel_dp->aux, DP_TEST_SINK,
|
||||||
|
buf & ~DP_TEST_SINK_START);
|
||||||
|
|
||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue