redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

gpio: mockup: use simple_read_from_buffer() in debugfs read callback 

Calling read() for a single byte read will return 2 currently. Use
simple_read_from_buffer() which correctly handles all sizes.

Fixes: 2a9e27408e ("gpio: mockup: rework debugfs interface")
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
hifive-unleashed-5.1
Bartosz Golaszewski 2019-03-28 11:38:06 +01:00
parent 2583303deb
commit ce9fb53c72
1 changed files with 2 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/gpio/gpio-mockup.c
View File

@ -204,10 +204,9 @@ static ssize_t gpio_mockup_debugfs_read(struct file *file,
struct gpio_mockup_chip *chip;
struct seq_file *sfile;
struct gpio_chip *gc;
int val, rv, cnt;
int val, cnt;
char buf[3];
if (*ppos != 0)
return 0;
@ -219,12 +218,7 @@ static ssize_t gpio_mockup_debugfs_read(struct file *file,
val = gpio_mockup_get(gc, priv->offset);
cnt = snprintf(buf, sizeof(buf), "%d\n", val);
rv = copy_to_user(usr_buf, buf, cnt);
if (rv)
return rv;
*ppos += cnt;
return cnt;
return simple_read_from_buffer(usr_buf, size, ppos, buf, cnt);
}
static ssize_t gpio_mockup_debugfs_write(struct file *file,