redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

scsi: aacraid: Fix a few kerneldoc issues

Browse source 
Functions must follow imediately after the header documenting them and all
parameters must be present.

Fixes the following W=1 kernel build warning(s):

 drivers/scsi/aacraid/commctrl.c:43: warning: Excess function parameter 'dev' description in 'AAC_DEBUG_PREAMBLE'
 drivers/scsi/aacraid/commctrl.c:43: warning: Excess function parameter 'arg' description in 'AAC_DEBUG_PREAMBLE'
 drivers/scsi/aacraid/commctrl.c:167: warning: Function parameter or member 'dev' not described in 'open_getadapter_fib'
 drivers/scsi/aacraid/commctrl.c:167: warning: Function parameter or member 'arg' not described in 'open_getadapter_fib'
 drivers/scsi/aacraid/commctrl.c:458: warning: Cannot understand  *
 on line 458 - I thought it was a doc line

Link: https://lore.kernel.org/r/20200713080001.128044-3-lee.jones@linaro.org
Cc: Adaptec OEM Raid Solutions <aacraid@microsemi.com>
Cc: "PMC-Sierra, Inc" <aacraid@pmc-sierra.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
Lee Jones 2020-07-13 08:59:39 +01:00 committed by Martin K. Petersen
parent b115958d91
commit cf93fffac2
1 changed files with 6 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
drivers/scsi/aacraid/commctrl.c
View file

@ -32,6 +32,8 @@
#include "aacraid.h" #include "aacraid.h"
# define AAC_DEBUG_PREAMBLE KERN_INFO
# define AAC_DEBUG_POSTAMBLE
/** /**
* ioctl_send_fib - send a FIB from userspace * ioctl_send_fib - send a FIB from userspace
* @dev: adapter is being processed * @dev: adapter is being processed
@ -40,9 +42,6 @@
* This routine sends a fib to the adapter on behalf of a user level * This routine sends a fib to the adapter on behalf of a user level
* program. * program.
*/ */
# define AAC_DEBUG_PREAMBLE KERN_INFO
# define AAC_DEBUG_POSTAMBLE
static int ioctl_send_fib(struct aac_dev * dev, void __user *arg) static int ioctl_send_fib(struct aac_dev * dev, void __user *arg)
{ {
struct hw_fib * kfib; struct hw_fib * kfib;
@ -158,11 +157,12 @@ cleanup:
/** /**
* open_getadapter_fib - Get the next fib * open_getadapter_fib - Get the next fib
* @dev: adapter is being processed
* @arg: arguments to the open call
* *
* This routine will get the next Fib, if available, from the AdapterFibContext * This routine will get the next Fib, if available, from the AdapterFibContext
* passed in from the user. * passed in from the user.
*/ */
static int open_getadapter_fib(struct aac_dev * dev, void __user *arg) static int open_getadapter_fib(struct aac_dev * dev, void __user *arg)
{ {
struct aac_fib_context * fibctx; struct aac_fib_context * fibctx;
@ -234,7 +234,6 @@ static int open_getadapter_fib(struct aac_dev * dev, void __user *arg)
* This routine will get the next Fib, if available, from the AdapterFibContext * This routine will get the next Fib, if available, from the AdapterFibContext
* passed in from the user. * passed in from the user.
*/ */
static int next_getadapter_fib(struct aac_dev * dev, void __user *arg) static int next_getadapter_fib(struct aac_dev * dev, void __user *arg)
{ {
struct fib_ioctl f; struct fib_ioctl f;
@ -455,11 +454,10 @@ static int check_revision(struct aac_dev *dev, void __user *arg)
/** /**
*
* aac_send_raw_scb * aac_send_raw_scb
* * @dev: adapter is being processed
* @arg: arguments to the send call
*/ */
static int aac_send_raw_srb(struct aac_dev* dev, void __user * arg) static int aac_send_raw_srb(struct aac_dev* dev, void __user * arg)
{ {
struct fib* srbfib; struct fib* srbfib;