redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

9p: Remove unnecessary IS_ERR() check 

The "fid" variable can't be an error pointer so there is no need to
check.  The code is slightly cleaner if we move the increment before
the break and remove the NULL check as well.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Dominique Martinet <asmadeus@codewreck.org>
zero-sugar-mainline-defconfig
Dan Carpenter 2020-12-01 10:04:34 +03:00 committed by Dominique Martinet
parent dfd375864a
commit cfd1d0f524
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
fs/9p/fid.c
View File

@ -56,12 +56,11 @@ static struct p9_fid *v9fs_fid_find_inode(struct inode *inode, kuid_t uid)
h = (struct hlist_head *)&inode->i_private;
hlist_for_each_entry(fid, h, ilist) {
if (uid_eq(fid->uid, uid)) {
refcount_inc(&fid->count);
ret = fid;
break;
}
}
if (ret && !IS_ERR(ret))
refcount_inc(&ret->count);
spin_unlock(&inode->i_lock);
return ret;
}