[SCSI] zfcp: fix dismissal of error recovery actions
zfcp_erp_action_dismiss() used to ignore any actions in the ready list. This is a bug. Any action superseded by a stronger action needs to be dismissed. This patch changes zfcp_erp_action_dismiss() so that it dismisses actions regardless of their list affiliation. The ERP thread is able to handle this. It is important to kick the erp thread only for actions in the running list, though, as an imbalance of wakeup signals would confuse the erp thread otherwise. Signed-off-by: Martin Peschke <mp3@de.ibm.com> Acked-by: Swen Schillig <swen@vnet.ibm.com> Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
This commit is contained in:
parent
5c1da582b3
commit
d0076f7754
|
@ -977,7 +977,9 @@ static void zfcp_erp_action_dismiss(struct zfcp_erp_action *erp_action)
|
||||||
debug_text_event(adapter->erp_dbf, 2, "a_adis");
|
debug_text_event(adapter->erp_dbf, 2, "a_adis");
|
||||||
debug_event(adapter->erp_dbf, 2, &erp_action->action, sizeof (int));
|
debug_event(adapter->erp_dbf, 2, &erp_action->action, sizeof (int));
|
||||||
|
|
||||||
zfcp_erp_async_handler_nolock(erp_action, ZFCP_STATUS_ERP_DISMISSED);
|
erp_action->status |= ZFCP_STATUS_ERP_DISMISSED;
|
||||||
|
if (zfcp_erp_action_exists(erp_action) == ZFCP_ERP_ACTION_RUNNING)
|
||||||
|
zfcp_erp_action_ready(erp_action);
|
||||||
}
|
}
|
||||||
|
|
||||||
int
|
int
|
||||||
|
|
Loading…
Reference in a new issue