redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

tracing, perf: Adjust code layout in get_recursion_context() 

In an XDP redirect applications using tracepoint xdp:xdp_redirect to
diagnose TX overrun, I noticed perf_swevent_get_recursion_context()
was consuming 2% CPU. This was reduced to 1.85% with this simple
change.

Looking at the annotated asm code, it was clear that the unlikely case
in_nmi() test was chosen (by the compiler) as the most likely
event/branch.  This small adjustment makes the compiler (GCC version
7.1.1 20170622 (Red Hat 7.1.1-3)) put in_nmi() as an unlikely branch.

Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/150342256382.16595.986861478681783732.stgit@firesoul
Signed-off-by: Ingo Molnar <mingo@kernel.org>
hifive-unleashed-5.1
Jesper Dangaard Brouer 2017-08-22 19:22:43 +02:00 committed by Ingo Molnar
parent 1d953111b6
commit d0618410ec
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
kernel/events/internal.h
View File

@ -208,7 +208,7 @@ static inline int get_recursion_context(int *recursion)
{
int rctx;
if (in_nmi())
if (unlikely(in_nmi()))
rctx = 3;
else if (in_irq())
rctx = 2;