Staging: dst: correct error-handling code
dst_state_alloc returns an ERR_PTR value in an error case instead of NULL. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @match exists@ expression x, E; statement S1, S2; @@ x = dst_state_alloc(...) ... when != x = E ( * if (x == NULL || ...) S1 else S2 | * if (x == NULL && ...) S1 else S2 ) // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
parent
b6ac161364
commit
d0e0507ad6
|
@ -159,7 +159,7 @@ static struct dst_state *dst_accept_client(struct dst_state *st)
|
||||||
goto err_out_exit;
|
goto err_out_exit;
|
||||||
|
|
||||||
new = dst_state_alloc(st->node);
|
new = dst_state_alloc(st->node);
|
||||||
if (!new) {
|
if (IS_ERR(new)) {
|
||||||
err = -ENOMEM;
|
err = -ENOMEM;
|
||||||
goto err_out_release;
|
goto err_out_release;
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in a new issue