redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

memory: tegra: Delete unneeded of_node_put() 

for_each_child_of_node() performs an of_node_put() on each iteration, so
putting an of_node_put() before a continue results in a double put.

The semantic match that finds this problem is as follows
(http://coccinelle.lip6.fr):

// <smpl>
@@
expression root,e;
local idexpression child;
iterator name for_each_child_of_node;
@@

 for_each_child_of_node(root, child) {
   ... when != of_node_get(child)
*  of_node_put(child);
   ...
*  continue;
}
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Thierry Reding <treding@nvidia.com>
hifive-unleashed-5.1
Julia Lawall 2015-10-09 19:47:40 +02:00 committed by Thierry Reding
parent aafb197f75
commit d1122e4b76
2 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/memory/tegra/mc.c
View File

@ -206,10 +206,8 @@ static int tegra_mc_setup_timings(struct tegra_mc *mc)
for_each_child_of_node(mc->dev->of_node, node) {
err = of_property_read_u32(node, "nvidia,ram-code",
&node_ram_code);
if (err || (node_ram_code != ram_code)) {
of_node_put(node);
if (err || (node_ram_code != ram_code))
continue;
}
err = load_timings(mc, node);
if (err)

4
drivers/memory/tegra/tegra124-emc.c
View File

@ -997,10 +997,8 @@ tegra_emc_find_node_by_ram_code(struct device_node *node, u32 ram_code)
u32 value;
err = of_property_read_u32(np, "nvidia,ram-code", &value);
if (err || (value != ram_code)) {
of_node_put(np);
if (err || (value != ram_code))
continue;
}
return np;
}