redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

vmwgfx: return -EFAULT instead of number of bytes remaining

Browse source 
The intent here was to return an error code, but instead the code
returns the number of bytes remaining (that weren't copied).

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Thomas Hellstrom <thellstrom@vmware.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
This commit is contained in:
Dan Carpenter 2011-10-18 09:09:19 +03:00 committed by Dave Airlie
parent bd8315c4a8
commit d2c184fb10
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c
View file

@ -150,6 +150,7 @@ int vmw_present_ioctl(struct drm_device *dev, void *data,
ret = copy_from_user(clips, clips_ptr, num_clips * sizeof(*clips)); ret = copy_from_user(clips, clips_ptr, num_clips * sizeof(*clips));
if (ret) { if (ret) {
DRM_ERROR("Failed to copy clip rects from userspace.\n"); DRM_ERROR("Failed to copy clip rects from userspace.\n");
ret = -EFAULT;
goto out_no_copy; goto out_no_copy;
} }
@ -241,6 +242,7 @@ int vmw_present_readback_ioctl(struct drm_device *dev, void *data,
ret = copy_from_user(clips, clips_ptr, num_clips * sizeof(*clips)); ret = copy_from_user(clips, clips_ptr, num_clips * sizeof(*clips));
if (ret) { if (ret) {
DRM_ERROR("Failed to copy clip rects from userspace.\n"); DRM_ERROR("Failed to copy clip rects from userspace.\n");
ret = -EFAULT;
goto out_no_copy; goto out_no_copy;
} }