redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

OMAPDSS: SDI: clean up regulator init 

Clean up the SDI driver's regulator init to remove the (unused)
omap_dss_device parameter, renaming the function to a more sensible
name, and making the code slightly clearer.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
hifive-unleashed-5.1
Tomi Valkeinen 2013-05-17 11:00:15 +03:00
parent e25001d8be
commit d37801b3a2
1 changed files with 11 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
drivers/video/omap2/dss/sdi.c
View File

@ -248,23 +248,22 @@ void omapdss_sdi_set_datapairs(struct omap_dss_device *dssdev, int datapairs)
} }
EXPORT_SYMBOL(omapdss_sdi_set_datapairs); EXPORT_SYMBOL(omapdss_sdi_set_datapairs);
static int sdi_init_display(struct omap_dss_device *dssdev) static int sdi_init_regulator(void)
{ {
DSSDBG("SDI init\n"); struct regulator *vdds_sdi;
if (sdi.vdds_sdi_reg == NULL) { if (sdi.vdds_sdi_reg)
struct regulator *vdds_sdi; return 0;
vdds_sdi = dss_get_vdds_sdi(); vdds_sdi = dss_get_vdds_sdi();
if (IS_ERR(vdds_sdi)) { if (IS_ERR(vdds_sdi)) {
DSSERR("can't get VDDS_SDI regulator\n"); DSSERR("can't get VDDS_SDI regulator\n");
return PTR_ERR(vdds_sdi); return PTR_ERR(vdds_sdi);
}
sdi.vdds_sdi_reg = vdds_sdi;
} }
sdi.vdds_sdi_reg = vdds_sdi;
return 0; return 0;
} }
@ -313,7 +312,7 @@ static int sdi_probe_pdata(struct platform_device *sdidev)
dss_copy_device_pdata(dssdev, plat_dssdev); dss_copy_device_pdata(dssdev, plat_dssdev);
r = sdi_init_display(dssdev); r = sdi_init_regulator();
if (r) { if (r) {
DSSERR("device %s init failed: %d\n", dssdev->name, r); DSSERR("device %s init failed: %d\n", dssdev->name, r);
dss_put_device(dssdev); dss_put_device(dssdev);