redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

[media] tda18212: use Kernel dev_* logging

Browse source 
Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
Antti Palosaari 2012-08-09 20:50:36 -03:00 committed by Mauro Carvalho Chehab
parent e666a44fa3
commit d46ddbe4bf
1 changed files with 14 additions and 21 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

35
drivers/media/common/tuners/tda18212.c
View file

@ -18,8 +18,6 @@
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
*/ */
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
#include "tda18212.h" #include "tda18212.h"
struct tda18212_priv { struct tda18212_priv {
@ -29,16 +27,6 @@ struct tda18212_priv {
u32 if_frequency; u32 if_frequency;
}; };
#define dbg(fmt, arg...) \
do { \
if (debug) \
pr_info("%s: " fmt, __func__, ##arg); \
} while (0)
static int debug;
module_param(debug, int, 0644);
MODULE_PARM_DESC(debug, "Turn on/off debugging (default:off).");
/* write multiple registers */ /* write multiple registers */
static int tda18212_wr_regs(struct tda18212_priv *priv, u8 reg, u8 *val, static int tda18212_wr_regs(struct tda18212_priv *priv, u8 reg, u8 *val,
int len) int len)
@ -61,8 +49,8 @@ static int tda18212_wr_regs(struct tda18212_priv *priv, u8 reg, u8 *val,
if (ret == 1) { if (ret == 1) {
ret = 0; ret = 0;
} else { } else {
pr_warn("i2c wr failed ret:%d reg:%02x len:%d\n", dev_warn(&priv->i2c->dev, "%s: i2c wr failed=%d reg=%02x " \
ret, reg, len); "len=%d\n", KBUILD_MODNAME, ret, reg, len);
ret = -EREMOTEIO; ret = -EREMOTEIO;
} }
return ret; return ret;
@ -93,8 +81,8 @@ static int tda18212_rd_regs(struct tda18212_priv *priv, u8 reg, u8 *val,
memcpy(val, buf, len); memcpy(val, buf, len);
ret = 0; ret = 0;
} else { } else {
pr_warn("i2c rd failed ret:%d reg:%02x len:%d\n", dev_warn(&priv->i2c->dev, "%s: i2c rd failed=%d reg=%02x " \
ret, reg, len); "len=%d\n", KBUILD_MODNAME, ret, reg, len);
ret = -EREMOTEIO; ret = -EREMOTEIO;
} }
@ -157,8 +145,10 @@ static int tda18212_set_params(struct dvb_frontend *fe)
[DVBC_8] = { 0x92, 0x53, 0x03 }, [DVBC_8] = { 0x92, 0x53, 0x03 },
}; };
dbg("delsys=%d RF=%d BW=%d\n", dev_dbg(&priv->i2c->dev,
c->delivery_system, c->frequency, c->bandwidth_hz); "%s: delivery_system=%d frequency=%d bandwidth_hz=%d\n",
__func__, c->delivery_system, c->frequency,
c->bandwidth_hz);
if (fe->ops.i2c_gate_ctrl) if (fe->ops.i2c_gate_ctrl)
fe->ops.i2c_gate_ctrl(fe, 1); /* open I2C-gate */ fe->ops.i2c_gate_ctrl(fe, 1); /* open I2C-gate */
@ -247,7 +237,7 @@ exit:
return ret; return ret;
error: error:
dbg("failed:%d\n", ret); dev_dbg(&priv->i2c->dev, "%s: failed=%d\n", __func__, ret);
goto exit; goto exit;
} }
@ -306,13 +296,16 @@ struct dvb_frontend *tda18212_attach(struct dvb_frontend *fe,
if (fe->ops.i2c_gate_ctrl) if (fe->ops.i2c_gate_ctrl)
fe->ops.i2c_gate_ctrl(fe, 0); /* close I2C-gate */ fe->ops.i2c_gate_ctrl(fe, 0); /* close I2C-gate */
dbg("ret:%d chip ID:%02x\n", ret, val); dev_dbg(&priv->i2c->dev, "%s: ret=%d chip id=%02x\n", __func__, ret,
val);
if (ret || val != 0xc7) { if (ret || val != 0xc7) {
kfree(priv); kfree(priv);
return NULL; return NULL;
} }
pr_info("NXP TDA18212HN successfully identified\n"); dev_info(&priv->i2c->dev,
"%s: NXP TDA18212HN successfully identified\n",
KBUILD_MODNAME);
memcpy(&fe->ops.tuner_ops, &tda18212_tuner_ops, memcpy(&fe->ops.tuner_ops, &tda18212_tuner_ops,
sizeof(struct dvb_tuner_ops)); sizeof(struct dvb_tuner_ops));