redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

x86/kaslr: Make the type of number of slots/slot areas consistent 

The number of slots can be 'unsigned int', since on 64-bit, the maximum
amount of memory is 2^52, the minimum alignment is 2^21, so the slot
number cannot be greater than 2^31. But in case future processors have
more than 52 physical address bits, make it 'unsigned long'.

The slot areas are limited by MAX_SLOT_AREA, currently 100. It is
indexed by an int, but the number of areas is stored as 'unsigned long'.
Change both to 'unsigned int' for consistency.

Signed-off-by: Arvind Sankar <nivedita@alum.mit.edu>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Link: https://lore.kernel.org/r/20200728225722.67457-15-nivedita@alum.mit.edu
zero-sugar-mainline-defconfig
Arvind Sankar 2020-07-28 18:57:15 -04:00 committed by Ingo Molnar
parent 3870d97179
commit d6d0f36c73
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
arch/x86/boot/compressed/kaslr.c
View File

@ -508,17 +508,15 @@ static bool mem_avoid_overlap(struct mem_vector *img,
struct slot_area {
unsigned long addr;
int num;
unsigned long num;
};
#define MAX_SLOT_AREA 100
static struct slot_area slot_areas[MAX_SLOT_AREA];
static unsigned int slot_area_index;
static unsigned long slot_max;
static unsigned long slot_area_index;
static void store_slot_info(struct mem_vector *region, unsigned long image_size)
{
struct slot_area slot_area;
@ -588,7 +586,7 @@ process_gb_huge_pages(struct mem_vector *region, unsigned long image_size)
static unsigned long slots_fetch_random(void)
{
unsigned long slot;
int i;
unsigned int i;
/* Handle case of no slots stored. */
if (slot_max == 0)