redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

net/can: can_dropped_invalid_skb can be boolean 

This patch makes can_dropped_invalid_skb return bool due to this
particular function only using either one or zero as its return
value.

No functional change.

Signed-off-by: Yaowei Bai <bywxiaobai@163.com>
Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
hifive-unleashed-5.1
Yaowei Bai 2015-10-08 21:28:57 +08:00 committed by David S. Miller
parent 875e082949
commit d6fbaea5f6
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
include/linux/can/dev.h
View File

@ -78,7 +78,7 @@ struct can_priv {
#define get_canfd_dlc(i) (min_t(__u8, (i), CANFD_MAX_DLC))
/* Drop a given socketbuffer if it does not contain a valid CAN frame. */
static inline int can_dropped_invalid_skb(struct net_device *dev,
static inline bool can_dropped_invalid_skb(struct net_device *dev,
struct sk_buff *skb)
{
const struct canfd_frame *cfd = (struct canfd_frame *)skb->data;
@ -94,12 +94,12 @@ static inline int can_dropped_invalid_skb(struct net_device *dev,
} else
goto inval_skb;
return 0;
return false;
inval_skb:
kfree_skb(skb);
dev->stats.tx_dropped++;
return 1;
return true;
}
static inline bool can_is_canfd_skb(const struct sk_buff *skb)