redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

crypto: x86/sha1-avx2 - Fix RBP usage 

Using RBP as a temporary register breaks frame pointer convention and
breaks stack traces when unwinding from an interrupt in the crypto code.

Use R11 instead of RBP.  Since R11 isn't a callee-saved register, it
doesn't need to be saved and restored on the stack.

Reported-by: Eric Biggers <ebiggers@google.com>
Reported-by: Peter Zijlstra <peterz@infradead.org>
Tested-by: Eric Biggers <ebiggers@google.com>
Acked-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
hifive-unleashed-5.1
Josh Poimboeuf 2017-09-18 14:42:05 -05:00 committed by Herbert Xu
parent 3ed7b4d67c
commit d7b1722c72
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
arch/x86/crypto/sha1_avx2_x86_64_asm.S
View File

@ -89,7 +89,7 @@
#define REG_RE %rdx
#define REG_RTA %r12
#define REG_RTB %rbx
#define REG_T1 %ebp
#define REG_T1 %r11d
#define xmm_mov vmovups
#define avx2_zeroupper vzeroupper
#define RND_F1 1
@ -637,7 +637,6 @@ _loop3:
ENTRY(\name)
push %rbx
push %rbp
push %r12
push %r13
push %r14
@ -673,7 +672,6 @@ _loop3:
pop %r14
pop %r13
pop %r12
pop %rbp
pop %rbx
ret