Input: ep93xx_keypad - pass correct pointer to free_irq()
free_irq() expects the same pointer that was passed to request_irq(), otherwise the IRQ is not freed. The issue was found using the following coccinelle script: <smpl> @r1@ type T; T devid; @@ request_irq(..., devid) @r2@ type r1.T; T devid; position p; @@ free_irq@p(..., devid) @@ position p != r2.p; @@ *free_irq@p(...) </smpl> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de> Acked-by: H Hartley Sweeten <hsweeten@visionengravers.com> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
This commit is contained in:
parent
edbbee595d
commit
d7ecfff184
|
@ -329,7 +329,7 @@ static int ep93xx_keypad_probe(struct platform_device *pdev)
|
||||||
return 0;
|
return 0;
|
||||||
|
|
||||||
failed_free_irq:
|
failed_free_irq:
|
||||||
free_irq(keypad->irq, pdev);
|
free_irq(keypad->irq, keypad);
|
||||||
failed_free_dev:
|
failed_free_dev:
|
||||||
input_free_device(input_dev);
|
input_free_device(input_dev);
|
||||||
failed_put_clk:
|
failed_put_clk:
|
||||||
|
@ -350,7 +350,7 @@ static int ep93xx_keypad_remove(struct platform_device *pdev)
|
||||||
struct ep93xx_keypad *keypad = platform_get_drvdata(pdev);
|
struct ep93xx_keypad *keypad = platform_get_drvdata(pdev);
|
||||||
struct resource *res;
|
struct resource *res;
|
||||||
|
|
||||||
free_irq(keypad->irq, pdev);
|
free_irq(keypad->irq, keypad);
|
||||||
|
|
||||||
if (keypad->enabled)
|
if (keypad->enabled)
|
||||||
clk_disable(keypad->clk);
|
clk_disable(keypad->clk);
|
||||||
|
|
Loading…
Reference in a new issue