redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

audit: Delete unnecessary checks before two function calls 

The functions consume_skb() and kfree_skb() test whether their argument
is NULL and then return immediately.
Thus the tests around their calls are not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
[PM: tweak patch prefix]
Signed-off-by: Paul Moore <pmoore@redhat.com>
hifive-unleashed-5.1
Markus Elfring 2016-01-13 09:18:55 -05:00 committed by Paul Moore
parent 1194b994be
commit d865e573b8
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
kernel/audit.c
View File

@ -508,8 +508,7 @@ static void flush_hold_queue(void)
* if auditd just disappeared but we
* dequeued an skb we need to drop ref
*/
if (skb)
consume_skb(skb);
consume_skb(skb);
}
static int kauditd_thread(void *dummy)
@ -1232,9 +1231,7 @@ static void audit_buffer_free(struct audit_buffer *ab)
if (!ab)
return;
if (ab->skb)
kfree_skb(ab->skb);
kfree_skb(ab->skb);
spin_lock_irqsave(&audit_freelist_lock, flags);
if (audit_freelist_count > AUDIT_MAXFREE)
kfree(ab);