redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

lkdtm: reorganize module paramaters

Browse source 
This reorganizes module parameters and global variables in the source
so they're grouped together with comments. Also moves early function
declarations to the top of the file.

Signed-off-by: Kees Cook <keescook@chromium.org>
This commit is contained in:
Kees Cook 2016-06-29 08:07:11 -07:00
parent 38f95fe296
commit d87c978830
1 changed files with 18 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

30
drivers/misc/lkdtm_core.c
View file

@ -51,6 +51,11 @@
#include "lkdtm.h" #include "lkdtm.h"
#define DEFAULT_COUNT 10
static int lkdtm_parse_commandline(void);
static void lkdtm_handler(void);
enum cname { enum cname {
CN_INVALID, CN_INVALID,
CN_INT_HARDWARE_ENTRY, CN_INT_HARDWARE_ENTRY,
@ -159,29 +164,30 @@ static char* cp_type[] = {
"USERCOPY_KERNEL", "USERCOPY_KERNEL",
}; };
/* Global jprobe entry and crashtype. */
static struct jprobe lkdtm_jprobe; static struct jprobe lkdtm_jprobe;
static int lkdtm_parse_commandline(void);
static void lkdtm_handler(void);
#define DEFAULT_COUNT 10
static char* cpoint_name;
static char* cpoint_type;
static int cpoint_count = DEFAULT_COUNT;
static int recur_count = -1;
static int crash_count = DEFAULT_COUNT;
static DEFINE_SPINLOCK(crash_count_lock);
static enum cname lkdtm_crashpoint = CN_INVALID; static enum cname lkdtm_crashpoint = CN_INVALID;
static enum ctype lkdtm_crashtype = CT_NONE; static enum ctype lkdtm_crashtype = CT_NONE;
/* Global crash counter and spinlock. */
static int crash_count = DEFAULT_COUNT;
static DEFINE_SPINLOCK(crash_count_lock);
/* Module parameters */
static int recur_count = -1;
module_param(recur_count, int, 0644); module_param(recur_count, int, 0644);
MODULE_PARM_DESC(recur_count, " Recursion level for the stack overflow test"); MODULE_PARM_DESC(recur_count, " Recursion level for the stack overflow test");
static char* cpoint_name;
module_param(cpoint_name, charp, 0444); module_param(cpoint_name, charp, 0444);
MODULE_PARM_DESC(cpoint_name, " Crash Point, where kernel is to be crashed"); MODULE_PARM_DESC(cpoint_name, " Crash Point, where kernel is to be crashed");
static char* cpoint_type;
module_param(cpoint_type, charp, 0444); module_param(cpoint_type, charp, 0444);
MODULE_PARM_DESC(cpoint_type, " Crash Point Type, action to be taken on "\ MODULE_PARM_DESC(cpoint_type, " Crash Point Type, action to be taken on "\
"hitting the crash point"); "hitting the crash point");
static int cpoint_count = DEFAULT_COUNT;
module_param(cpoint_count, int, 0644); module_param(cpoint_count, int, 0644);
MODULE_PARM_DESC(cpoint_count, " Crash Point Count, number of times the "\ MODULE_PARM_DESC(cpoint_count, " Crash Point Count, number of times the "\
"crash point is to be hit to trigger action"); "crash point is to be hit to trigger action");