redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

hpsa: logical vs bitwise AND typo 

HPSA_DIAG_OPTS_DISABLE_RLD_CACHING is a mask and bitwise AND was
intended here instead of logical &&.  This bug is essentially harmless,
it means that sometimes we don't print a warning message which we wanted
to print.

Fixes: c2adae44e9 ('hpsa: disable report lun data caching')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Acked-by: Don Brace <don.brace@pmcs.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
hifive-unleashed-5.1
Dan Carpenter 2015-11-12 12:43:38 +03:00 committed by Martin K. Petersen
parent 78b7b80cf0
commit d8a080c374
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/scsi/hpsa.c
View File

@ -8679,7 +8679,7 @@ static void hpsa_disable_rld_caching(struct ctlr_info *h)
if ((rc != 0) || (c->err_info->CommandStatus != 0))
goto errout;
if (*options && HPSA_DIAG_OPTS_DISABLE_RLD_CACHING)
if (*options & HPSA_DIAG_OPTS_DISABLE_RLD_CACHING)
goto out;
errout: