redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

checkpatch: fix UNNECESSARY_KERN_LEVEL false positive 

KERN_<LEVEL> is never redundant with printk_ratelimited or printk_once.
(Except perhaps in the sense that you could use e.g.  pr_err_ratelimited
or pr_err_once, but that would apply to printk as well).

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Cc: Andy Whitcroft <apw@canonical.com>
Acked-by: Joe Perches <joe@perches.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
hifive-unleashed-5.1
Paolo Bonzini 2015-02-13 14:38:26 -08:00 committed by Linus Torvalds
parent e23ef1f334
commit dcaf112365
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
scripts/checkpatch.pl
View File

@ -4547,7 +4547,7 @@ sub process {
}
# check for logging functions with KERN_<LEVEL>
if ($line !~ /printk\s*\(/ &&
if ($line !~ /printk(?:_ratelimited|_once)?\s*\(/ &&
$line =~ /\b$logFunctions\s*\(.*\b(KERN_[A-Z]+)\b/) {
my $level = $1;
if (WARN("UNNECESSARY_KERN_LEVEL",