redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

remoteproc: don't use virtio's weak barriers 

When creating a virtqueue for rpmsg, tell virtio we're not interested
in "weak" smp barriers, since we're talking to a real device.

On ARM, this means using a DSB instead of a DMB, which is needed
for platforms that kick the remote processor using some kind of
a mailbox device mapped to Device memory (otherwise the kick can
jump ahead and wake the remote processor before it has observed
the changes to the vrings).

Signed-off-by: Ohad Ben-Cohen <ohad@wizery.com>
hifive-unleashed-5.1
Ohad Ben-Cohen 2012-01-12 09:26:57 +02:00
parent b719587eb4
commit dd6da1c5e9
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/remoteproc/remoteproc_rpmsg.c
View File

@ -96,7 +96,11 @@ static struct virtqueue *rp_find_vq(struct virtio_device *vdev,
dev_dbg(rproc->dev, "vring%d: va %p qsz %d\n", id, addr, len);
vq = vring_new_virtqueue(len, AMP_VRING_ALIGN, vdev, addr,
/*
* Create the new vq, and tell virtio we're not interested in
* the 'weak' smp barriers, since we're talking with a real device.
*/
vq = vring_new_virtqueue(len, AMP_VRING_ALIGN, vdev, false, addr,
rproc_virtio_notify, callback, name);
if (!vq) {
dev_err(rproc->dev, "vring_new_virtqueue %s failed\n", name);