redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

m68k/math-emu: unsigned issue, 'unsigned long' will never be less than zero 

'oldmant.m32[1]' is 'unsigned long' which can never be '< 0', and the
original author wanted to check whether the highest bit is set.

So make the bit test explicit (which is better than casting from 'unsigned
long' to 'long').

The related warning: (with EXTRA_CFLAGS=-W ARCH=m68k for allmodconfig)
  arch/m68k/math-emu/fp_arith.c:522:4: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]

Signed-off-by: Chen Gang <gang.chen@asianux.com>
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
hifive-unleashed-5.1
Chen Gang 2013-05-30 16:21:36 +08:00 committed by Geert Uytterhoeven
parent 220921a0d1
commit ddc2fc2c5b
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
arch/m68k/math-emu/fp_arith.c
View File

@ -519,7 +519,7 @@ static void fp_roundint(struct fp_ext *dest, int mode)
return;
break;
case 0x401e:
if (!(oldmant.m32[1] >= 0))
if (oldmant.m32[1] & 0x80000000)
return;
if (oldmant.m32[0] & 1)
break;