redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

x86: atomic64: Clean up atomic64_sub_and_test() and atomic64_add_negative()

Browse source 
Linus noticed that the variable name 'old_val' is
confusingly named in these functions - the correct
naming is 'new_val'.

Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: David Howells <dhowells@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Arnd Bergmann <arnd@arndb.de>
LKML-Reference: <alpine.LFD.2.01.0907030942260.3210@localhost.localdomain>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
This commit is contained in:
Ingo Molnar 2009-07-03 20:11:30 +02:00
parent 3a8d1788b3
commit ddf9a003d3
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
arch/x86/lib/atomic64_32.c
View file

@ -175,9 +175,9 @@ EXPORT_SYMBOL(atomic64_sub);
*/
int atomic64_sub_and_test(u64 delta, atomic64_t *ptr)
{
u64 old_val = atomic64_sub_return(delta, ptr);
u64 new_val = atomic64_sub_return(delta, ptr);
return old_val == 0;
return new_val == 0;
}
EXPORT_SYMBOL(atomic64_sub_and_test);
@ -244,8 +244,8 @@ EXPORT_SYMBOL(atomic64_inc_and_test);
*/
int atomic64_add_negative(u64 delta, atomic64_t *ptr)
{
long long old_val = atomic64_add_return(delta, ptr);
s64 new_val = atomic64_add_return(delta, ptr);
return old_val < 0;
return new_val < 0;
}
EXPORT_SYMBOL(atomic64_add_negative);