V4L/DVB (12199): remove redundant tests on unsigned
input, inp and i are unsigned. When negative they are wrapped and caught by the other test. Cc: Andy Walls <awalls@radix.net> Signed-off-by: Roel Kluin <roel.kluin@gmail.com> Signed-off-by: Douglas Schilling Landgraf <dougsland@redhat.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
parent
ce27cd3bf9
commit
de81c3c3f5
|
@ -490,7 +490,7 @@ static int vidioc_s_input(struct file *file, void *fh, unsigned int input)
|
|||
if (!av7110->analog_tuner_flags)
|
||||
return 0;
|
||||
|
||||
if (input < 0 || input >= 4)
|
||||
if (input >= 4)
|
||||
return -EINVAL;
|
||||
|
||||
av7110->current_input = input;
|
||||
|
|
|
@ -605,7 +605,7 @@ int cx18_s_input(struct file *file, void *fh, unsigned int inp)
|
|||
if (ret)
|
||||
return ret;
|
||||
|
||||
if (inp < 0 || inp >= cx->nof_inputs)
|
||||
if (inp >= cx->nof_inputs)
|
||||
return -EINVAL;
|
||||
|
||||
if (inp == cx->active_input) {
|
||||
|
|
|
@ -1790,7 +1790,7 @@ static int saa7134_s_input(struct file *file, void *priv, unsigned int i)
|
|||
if (0 != err)
|
||||
return err;
|
||||
|
||||
if (i < 0 || i >= SAA7134_INPUT_MAX)
|
||||
if (i >= SAA7134_INPUT_MAX)
|
||||
return -EINVAL;
|
||||
if (NULL == card_in(dev, i).name)
|
||||
return -EINVAL;
|
||||
|
|
Loading…
Reference in a new issue