redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

stmmac: drop unnecessary dt checks in stmmac_probe_config_dt

Browse source 
Since the caller already check the presence of a of_node there
is no need to repeat the check in stmmac_probe_config_dt.

There is also no point in checking the return value of the
of_match_device function since if there wasn't match in the
first place we would never be in this function.

Signed-off-by: Joachim Eastwood <manabian@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Joachim Eastwood 2015-05-20 20:03:09 +02:00 committed by David S. Miller
parent 15ffac73bb
commit def5cd3cfd
1 changed files with 0 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
View file

@ -112,13 +112,7 @@ static int stmmac_probe_config_dt(struct platform_device *pdev,
const struct of_device_id *device; const struct of_device_id *device;
struct device *dev = &pdev->dev; struct device *dev = &pdev->dev;
if (!np)
return -ENODEV;
device = of_match_device(dev->driver->of_match_table, dev); device = of_match_device(dev->driver->of_match_table, dev);
if (!device)
return -ENODEV;
if (device->data) { if (device->data) {
const struct stmmac_of_data *data = device->data; const struct stmmac_of_data *data = device->data;
plat->has_gmac = data->has_gmac; plat->has_gmac = data->has_gmac;