staging: drm/imx: ipu-dc: signedness bug in ipu_dc_init_sync()
"map" needs to be signed for the error handling to work. In the success case then it holds a small non-negative value. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Acked-by: Sascha Hauer <s.hauer@pengutronix.de> Acked-by: Marek Vasut <marex@denx.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
234ad18249
commit
df2da9a3fc
|
@ -161,14 +161,15 @@ int ipu_dc_init_sync(struct ipu_dc *dc, struct ipu_di *di, bool interlaced,
|
||||||
u32 pixel_fmt, u32 width)
|
u32 pixel_fmt, u32 width)
|
||||||
{
|
{
|
||||||
struct ipu_dc_priv *priv = dc->priv;
|
struct ipu_dc_priv *priv = dc->priv;
|
||||||
u32 reg = 0, map;
|
u32 reg = 0;
|
||||||
|
int map;
|
||||||
|
|
||||||
dc->di = ipu_di_get_num(di);
|
dc->di = ipu_di_get_num(di);
|
||||||
|
|
||||||
map = ipu_pixfmt_to_map(pixel_fmt);
|
map = ipu_pixfmt_to_map(pixel_fmt);
|
||||||
if (map < 0) {
|
if (map < 0) {
|
||||||
dev_dbg(priv->dev, "IPU_DISP: No MAP\n");
|
dev_dbg(priv->dev, "IPU_DISP: No MAP\n");
|
||||||
return -EINVAL;
|
return map;
|
||||||
}
|
}
|
||||||
|
|
||||||
if (interlaced) {
|
if (interlaced) {
|
||||||
|
|
Loading…
Reference in a new issue