1
0
Fork 0

Staging: otus: Drop an unnecessary NULL test

Apparently, the NULL test is not necessary at this point.

The semantic patch that finds this problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@
type T;
expression E;
identifier i,fld;
statement S;
@@

- T i = E->fld;
+ T i;
  ... when != E
      when != i
  if (E == NULL) S
+ i = E->fld;
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Jiri Slaby <jirislaby@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
hifive-unleashed-5.1
Julia Lawall 2009-07-11 10:32:23 +02:00 committed by Greg Kroah-Hartman
parent 92e6765f40
commit df6785681b
1 changed files with 0 additions and 5 deletions

View File

@ -1015,11 +1015,6 @@ void kevent(struct work_struct *work)
container_of(work, struct usbdrv_private, kevent);
zdev_t *dev = macp->device;
if (macp == NULL)
{
return;
}
if (test_and_set_bit(0, (void *)&smp_kevent_Lock))
{
//schedule_work(&macp->kevent);