1
0
Fork 0

arm64/debug: Mask off all reserved bits from generated ESR values

There are only 16 comment bits in a BRK instruction, which
correspond to ESR bits 15:0.  Bits 24:16 of the ESR are RES0,
and might have weird meanings in the future.

This code inserts 16 bits of comment in the ESR value instead of
20 (almost certainly a typo in the original code).

Signed-off-by: Dave Martin <Dave.Martin@arm.com>
Acked-by: Mark Rutland <mark.rutland@arm.com>
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
hifive-unleashed-5.1
Dave P Martin 2015-07-24 16:37:42 +01:00 committed by Will Deacon
parent 951757ae83
commit dfac68314c
1 changed files with 1 additions and 1 deletions

View File

@ -45,7 +45,7 @@
/*
* ESR values expected for dynamic and compile time BRK instruction
*/
#define DBG_ESR_VAL_BRK(x) (0xf2000000 | ((x) & 0xfffff))
#define DBG_ESR_VAL_BRK(x) (0xf2000000 | ((x) & 0xffff))
/*
* #imm16 values used for BRK instruction generation