redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

staging: mt7621-mmc: Remove error message in debug

Browse source 
If the debug file in proc fs is not successfully created current code
prints an error message, this is removed. de is also not an error
pointer, so the IS_ERR() call leads to a static checker warning. The
unused return value of the msdc_debug_proc_init function is also removed.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Christian Lütke-Stetzkamp <christian@lkamp.de>
Reviewed-by: NeilBrown <neil@brown.name>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Christian Lütke-Stetzkamp 2018-04-07 10:16:22 +02:00 committed by Greg Kroah-Hartman
parent 997ae819a8
commit e1b8ebd25d
2 changed files with 3 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
drivers/staging/mt7621-mmc/dbg.c
View file

@ -337,14 +337,9 @@ static const struct file_operations msdc_debug_fops = {
.release = single_release,
};
int msdc_debug_proc_init(void)
void msdc_debug_proc_init(void)
{
struct proc_dir_entry *de = proc_create("msdc_debug", 0667, NULL, &msdc_debug_fops);
if (!de || IS_ERR(de))
printk("!! Create MSDC debug PROC fail !!\n");
return 0;
proc_create("msdc_debug", 0667, NULL, &msdc_debug_fops);
}
EXPORT_SYMBOL_GPL(msdc_debug_proc_init);
#endif

2
drivers/staging/mt7621-mmc/dbg.h
View file

@ -146,7 +146,7 @@ do { \
} while (0);
#endif
int msdc_debug_proc_init(void);
void msdc_debug_proc_init(void);
#if 0 /* --- chhung */
void msdc_init_gpt(void);