redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

of_mdio: kill useless variable in of_phy_register_fixed_link() 

of_phy_register_fixed_link() declares the 'err' variable to hold the result
of of_property_read_string() but only uses it once after that, while that
function can be called directly from the *if* statement...

Remove that variable and move/regroup 'link_gpio' and 'len' variables in
order to sort the declarations in the reverse Xmas tree order -- to please
DaveM. ;-)

Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
hifive-unleashed-5.1
Sergei Shtylyov 2017-07-23 21:45:47 +03:00 committed by David S. Miller
parent a28b1b90de
commit e470e4f787
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/of/of_mdio.c
View File

@ -422,13 +422,11 @@ int of_phy_register_fixed_link(struct device_node *np)
struct fixed_phy_status status = {};
struct device_node *fixed_link_node;
const __be32 *fixed_link_prop;
int link_gpio;
int len, err;
struct phy_device *phy;
const char *managed;
int link_gpio, len;
err = of_property_read_string(np, "managed", &managed);
if (err == 0) {
if (of_property_read_string(np, "managed", &managed) == 0) {
if (strcmp(managed, "in-band-status") == 0) {
/* status is zeroed, namely its .link member */
phy = fixed_phy_register(PHY_POLL, &status, -1, np);