redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

greybus: battery: fix panic on operation error

Browse source 
If an operation times out or otherwise returns an error, val->intval
should not be set and an error-code should be returned.

Fixes a panic on unload while receiving -ENOTCONN.

Signed-off-by: Perry Hung <perry@leaflabs.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
This commit is contained in:
Perry Hung 2015-07-24 19:02:29 -04:00 committed by Greg Kroah-Hartman
parent 23119de4e6
commit e619e8505b
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/staging/greybus/battery.c
View file

@ -281,7 +281,7 @@ static int get_property(struct power_supply *b,
return -EINVAL; return -EINVAL;
} }
return 0; return (val->intval < 0) ? val->intval : 0;
} }
// FIXME - verify this list, odds are some can be removed and others added. // FIXME - verify this list, odds are some can be removed and others added.