redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

greybus: svc: print an error message on failed eject attempts 

Print an error message when the SVC fails to eject an interface.

Signed-off-by: Johan Hovold <johan@hovoldconsulting.com>
Reviewed-by: Jeffrey Carlyle <jcarlyle@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
hifive-unleashed-5.1
Johan Hovold 2016-03-09 12:20:45 +01:00 committed by Greg Kroah-Hartman
parent c80514a39a
commit e676ccd713
1 changed files with 11 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
drivers/staging/greybus/svc.c
View File

@ -131,6 +131,7 @@ EXPORT_SYMBOL_GPL(gb_svc_intf_reset);
int gb_svc_intf_eject(struct gb_svc *svc, u8 intf_id)
{
struct gb_svc_intf_eject_request request;
int ret;
request.intf_id = intf_id;
@ -138,10 +139,16 @@ int gb_svc_intf_eject(struct gb_svc *svc, u8 intf_id)
* The pulse width for module release in svc is long so we need to
* increase the timeout so the operation will not return to soon.
*/
return gb_operation_sync_timeout(svc->connection,
GB_SVC_TYPE_INTF_EJECT, &request,
sizeof(request), NULL, 0,
GB_SVC_EJECT_TIME);
ret = gb_operation_sync_timeout(svc->connection,
GB_SVC_TYPE_INTF_EJECT, &request,
sizeof(request), NULL, 0,
GB_SVC_EJECT_TIME);
if (ret) {
dev_err(&svc->dev, "failed to eject interface %u\n", intf_id);
return ret;
}
return 0;
}
int gb_svc_dme_peer_get(struct gb_svc *svc, u8 intf_id, u16 attr, u16 selector,