redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

nexthop: Unlink nexthop group entry in error path 

[ Upstream commit 7b01e53eee ]

In case of error, remove the nexthop group entry from the list to which
it was previously added.

Fixes: 430a049190 ("nexthop: Add support for nexthop groups")
Signed-off-by: Ido Schimmel <idosch@nvidia.com>
Reviewed-by: Petr Machata <petrm@nvidia.com>
Reviewed-by: David Ahern <dsahern@kernel.org>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5.4-rM2-2.2.x-imx-squashed
Ido Schimmel 2021-01-07 16:48:22 +02:00 committed by Greg Kroah-Hartman
parent 3cecab93f2
commit e6931e3eb0
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
net/ipv4/nexthop.c
View File

@ -1157,8 +1157,10 @@ static struct nexthop *nexthop_create_group(struct net *net,
return nh;
out_no_nh:
for (i--; i >= 0; --i)
for (i--; i >= 0; --i) {
list_del(&nhg->nh_entries[i].nh_list);
nexthop_put(nhg->nh_entries[i].nh);
}
kfree(nhg->spare);
kfree(nhg);