redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

regulator: act8865: Remove "too many regulators" error handler 

The check would dereference pdata, which can be NULL in the non-DT
use case.

Nothing will break if pdata->num_regulators is larger than the number
of regulators that the driver defines: pdata->num_regulators is only
read in act8865_get_init_data() to iterate through pdata->regulators.

The error handler might have some value as a sanity check on the
platform data, but the platform data could be broken in many other
ways that are not checked for (unknown IDs, duplicate IDs), so I see
no reason to perform only this specific check.

Signed-off-by: Maarten ter Huurne <maarten@treewalker.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
hifive-unleashed-5.1
Maarten ter Huurne 2016-03-17 15:05:06 +01:00 committed by Mark Brown
parent de14ba6737
commit e6e79fd9ce
1 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/regulator/act8865-regulator.c
View File

@ -485,12 +485,6 @@ static int act8865_pmic_probe(struct i2c_client *client,
pdata = &pdata_of;
}
if (pdata->num_regulators > num_regulators) {
dev_err(dev, "too many regulators: %d\n",
pdata->num_regulators);
return -EINVAL;
}
act8865 = devm_kzalloc(dev, sizeof(struct act8865), GFP_KERNEL);
if (!act8865)
return -ENOMEM;