redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

IB/srp: replace custom implementation of hex2bin() 

There is no need to have a duplication of the generic library, i.e.
hex2bin().

Replace the open coded variant.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Bart Van Assche <bart.vanassche@wdc.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
hifive-unleashed-5.1
Andy Shevchenko 2017-12-11 15:05:05 +02:00 committed by Jason Gunthorpe
parent 1b19b95169
commit e711f968c4
1 changed files with 3 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
drivers/infiniband/ulp/srp/ib_srp.c
View File

@ -3110,7 +3110,6 @@ static int srp_parse_options(const char *buf, struct srp_target_port *target)
{
char *options, *sep_opt;
char *p;
char dgid[3];
substring_t args[MAX_OPT_ARGS];
int opt_mask = 0;
int token;
@ -3162,16 +3161,10 @@ static int srp_parse_options(const char *buf, struct srp_target_port *target)
goto out;
}
for (i = 0; i < 16; ++i) {
strlcpy(dgid, p + i * 2, sizeof(dgid));
if (sscanf(dgid, "%hhx",
&target->orig_dgid.raw[i]) < 1) {
ret = -EINVAL;
kfree(p);
goto out;
}
}
ret = hex2bin(target->orig_dgid.raw, p, 16);
kfree(p);
if (ret < 0)
goto out;
break;
case SRP_OPT_PKEY: