redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

ata: sata_mv: Replace mdelay with usleep_range in mv_reset_channel 

After checking all possible call chains to mv_reset_channel here,
my tool finds that mv_reset_channel is never called in atomic context,
namely never in an interrupt handler or holding a spinlock.
Thus mdelay can be replaced with usleep_range to avoid busy wait.

This is found by a static analysis tool named DCNS written by myself.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
hifive-unleashed-5.1
Jia-Ju Bai 2018-01-25 18:26:52 +08:00 committed by Tejun Heo
parent 6590425218
commit e72685dbd2
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/ata/sata_mv.c
View File

@ -3596,7 +3596,7 @@ static void mv_reset_channel(struct mv_host_priv *hpriv, void __iomem *mmio,
hpriv->ops->phy_errata(hpriv, mmio, port_no);
if (IS_GEN_I(hpriv))
mdelay(1);
usleep_range(500, 1000);
}
static void mv_pmp_select(struct ata_port *ap, int pmp)