redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

scsi: ufs: remove unnecessary query(DM) UPIU trace 

This patch removes redundant trace that occurs when sending Device
Management(DM) request (fix behavior in commit 6667e6d91c ("scsi:
ufs: add trace event for ufs upiu").

Since the function send_command is called also for DM request, UPIU
trace for DM request is called twice- one identified as query_* the
other as send/complete.

Signed-off-by: Ohad Sharabi <ohad.sharabi@wdc.com>
Fixes: 6667e6d91c ("scsi: ufs: add trace event for ufs upiu")
Reviewed-by: Stanislav Nijnikov <stanislav.nijnikov@wdc.com>
Reviewed-by: Avri Altman <avri.altman@wdc.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
hifive-unleashed-5.1
Ohad Sharabi 2018-08-05 16:26:23 +03:00 committed by Martin K. Petersen
parent e9f7be0c43
commit e7c3b37983
1 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
drivers/scsi/ufs/ufshcd.c
View File

@ -342,18 +342,19 @@ static void ufshcd_add_command_trace(struct ufs_hba *hba,
sector_t lba = -1; sector_t lba = -1;
u8 opcode = 0; u8 opcode = 0;
u32 intr, doorbell; u32 intr, doorbell;
struct ufshcd_lrb *lrbp; struct ufshcd_lrb *lrbp = &hba->lrb[tag];
int transfer_len = -1; int transfer_len = -1;
/* trace UPIU also */ if (!trace_ufshcd_command_enabled()) {
ufshcd_add_cmd_upiu_trace(hba, tag, str); /* trace UPIU W/O tracing command */
if (lrbp->cmd)
if (!trace_ufshcd_command_enabled()) ufshcd_add_cmd_upiu_trace(hba, tag, str);
return; return;
}
lrbp = &hba->lrb[tag];
if (lrbp->cmd) { /* data phase exists */ if (lrbp->cmd) { /* data phase exists */
/* trace UPIU also */
ufshcd_add_cmd_upiu_trace(hba, tag, str);
opcode = (u8)(*lrbp->cmd->cmnd); opcode = (u8)(*lrbp->cmd->cmnd);
if ((opcode == READ_10) || (opcode == WRITE_10)) { if ((opcode == READ_10) || (opcode == WRITE_10)) {
/* /*