redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

perf: Add cond_resched() to task_function_call() 

commit 2ed6edd33a upstream.

Under rare circumstances, task_function_call() can repeatedly fail and
cause a soft lockup.

There is a slight race where the process is no longer running on the cpu
we targeted by the time remote_function() runs.  The code will simply
try again.  If we are very unlucky, this will continue to fail, until a
watchdog fires.  This can happen in a heavily loaded, multi-core virtual
machine.

Reported-by: syzbot+bb4935a5c09b5ff79940@syzkaller.appspotmail.com
Signed-off-by: Barret Rhoden <brho@google.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/20200414222920.121401-1-brho@google.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5.4-rM2-2.2.x-imx-squashed
Barret Rhoden 2020-04-14 18:29:20 -04:00 committed by Greg Kroah-Hartman
parent e0544273b7
commit e81b05e535
1 changed files with 14 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
kernel/events/core.c
View File

@ -93,11 +93,11 @@ static void remote_function(void *data)
* @info: the function call argument * @info: the function call argument
* *
* Calls the function @func when the task is currently running. This might * Calls the function @func when the task is currently running. This might
* be on the current CPU, which just calls the function directly * be on the current CPU, which just calls the function directly. This will
* retry due to any failures in smp_call_function_single(), such as if the
* task_cpu() goes offline concurrently.
* *
* returns: @func return value, or * returns @func return value or -ESRCH when the process isn't running
* -ESRCH - when the process isn't running
* -EAGAIN - when the process moved away
*/ */
static int static int
task_function_call(struct task_struct *p, remote_function_f func, void *info) task_function_call(struct task_struct *p, remote_function_f func, void *info)
@ -110,11 +110,16 @@ task_function_call(struct task_struct *p, remote_function_f func, void *info)
}; };
int ret; int ret;
do { for (;;) {
ret = smp_call_function_single(task_cpu(p), remote_function, &data, 1); ret = smp_call_function_single(task_cpu(p), remote_function,
if (!ret) &data, 1);
ret = data.ret; ret = !ret ? data.ret : -EAGAIN;
} while (ret == -EAGAIN);
if (ret != -EAGAIN)
break;
cond_resched();
}
return ret; return ret;
} }