redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

[SCSI] qla2xxx: Fix incorrect test after list_for_each_entry() exits.

Browse source 
list_for_each_entry() never leaves the iterator pointing to null.

Signed-off-by: Joe Carnuccio <joe.carnuccio@qlogic.com>
Signed-off-by: Saurav Kashyap <saurav.kashyap@qlogic.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
This commit is contained in:
Joe Carnuccio 2013-08-27 01:37:29 -04:00 committed by James Bottomley
parent 7ec0effd30
commit e8b8b8ad6e
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
drivers/scsi/qla2xxx/qla_bsg.c
View file

@ -1266,6 +1266,7 @@ qla24xx_iidma(struct fc_bsg_job *bsg_job)
int rval = 0; int rval = 0;
struct qla_port_param *port_param = NULL; struct qla_port_param *port_param = NULL;
fc_port_t *fcport = NULL; fc_port_t *fcport = NULL;
int found = 0;
uint16_t mb[MAILBOX_REGISTER_COUNT]; uint16_t mb[MAILBOX_REGISTER_COUNT];
uint8_t *rsp_ptr = NULL; uint8_t *rsp_ptr = NULL;
@ -1288,10 +1289,12 @@ qla24xx_iidma(struct fc_bsg_job *bsg_job)
if (memcmp(port_param->fc_scsi_addr.dest_addr.wwpn, if (memcmp(port_param->fc_scsi_addr.dest_addr.wwpn,
fcport->port_name, sizeof(fcport->port_name))) fcport->port_name, sizeof(fcport->port_name)))
continue; continue;
found = 1;
break; break;
} }
if (!fcport) { if (!found) {
ql_log(ql_log_warn, vha, 0x7049, ql_log(ql_log_warn, vha, 0x7049,
"Failed to find port.\n"); "Failed to find port.\n");
return -EINVAL; return -EINVAL;