usblp: Make use of URB_FREE_BUFFER
Employ the new API URB_FREE_BUFFER that we've got. There was talk of a combined constructor for this case, but apparently it's not happening, so just set the flag explicitly for now. Signed-off-by: Pete Zaitcev <zaitcev@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>hifive-unleashed-5.1
parent
7f477358e2
commit
e8fa0ce65c
|
@ -331,9 +331,6 @@ static void usblp_bulk_write(struct urb *urb)
|
||||||
wake_up(&usblp->wwait);
|
wake_up(&usblp->wwait);
|
||||||
spin_unlock(&usblp->lock);
|
spin_unlock(&usblp->lock);
|
||||||
|
|
||||||
/* XXX Use usb_setup_bulk_urb when available. Talk to Marcel. */
|
|
||||||
kfree(urb->transfer_buffer);
|
|
||||||
urb->transfer_buffer = NULL; /* Not refcounted, so to be safe... */
|
|
||||||
usb_free_urb(urb);
|
usb_free_urb(urb);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -719,6 +716,7 @@ static ssize_t usblp_write(struct file *file, const char __user *buffer, size_t
|
||||||
usb_sndbulkpipe(usblp->dev,
|
usb_sndbulkpipe(usblp->dev,
|
||||||
usblp->protocol[usblp->current_protocol].epwrite->bEndpointAddress),
|
usblp->protocol[usblp->current_protocol].epwrite->bEndpointAddress),
|
||||||
writebuf, transfer_length, usblp_bulk_write, usblp);
|
writebuf, transfer_length, usblp_bulk_write, usblp);
|
||||||
|
writeurb->transfer_flags |= URB_FREE_BUFFER;
|
||||||
usb_anchor_urb(writeurb, &usblp->urbs);
|
usb_anchor_urb(writeurb, &usblp->urbs);
|
||||||
|
|
||||||
if (copy_from_user(writebuf,
|
if (copy_from_user(writebuf,
|
||||||
|
|
Loading…
Reference in New Issue