redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

wireless: remove print_mac uses 

Use %pM instead, and also remove stray variables
declared with DECLARE_MAC_BUF.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Acked-by: Kalle Valo <kalle.valo@nokia.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
hifive-unleashed-5.1
Johannes Berg 2009-07-15 17:21:41 +02:00 committed by John W. Linville
parent 04dc882d60
commit e91d83346a
7 changed files with 9 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
drivers/net/wireless/ath/ar9170/main.c
View File

@ -2628,7 +2628,6 @@ static int ar9170_read_eeprom(struct ar9170 *ar)
{ {
#define RW 8 /* number of words to read at once */ #define RW 8 /* number of words to read at once */
#define RB (sizeof(u32) * RW) #define RB (sizeof(u32) * RW)
DECLARE_MAC_BUF(mbuf);
u8 *eeprom = (void *)&ar->eeprom; u8 *eeprom = (void *)&ar->eeprom;
u8 *addr = ar->eeprom.mac_address; u8 *addr = ar->eeprom.mac_address;
__le32 offsets[RW]; __le32 offsets[RW];

4
drivers/net/wireless/b43/main.c
View File

@ -938,7 +938,6 @@ static void b43_clear_keys(struct b43_wldev *dev)
static void b43_dump_keymemory(struct b43_wldev *dev) static void b43_dump_keymemory(struct b43_wldev *dev)
{ {
unsigned int i, index, offset; unsigned int i, index, offset;
DECLARE_MAC_BUF(macbuf);
u8 mac[ETH_ALEN]; u8 mac[ETH_ALEN];
u16 algo; u16 algo;
u32 rcmta0; u32 rcmta0;
@ -973,8 +972,7 @@ static void b43_dump_keymemory(struct b43_wldev *dev)
((index - 4) * 2) + 1); ((index - 4) * 2) + 1);
*((__le32 *)(&mac[0])) = cpu_to_le32(rcmta0); *((__le32 *)(&mac[0])) = cpu_to_le32(rcmta0);
*((__le16 *)(&mac[4])) = cpu_to_le16(rcmta1); *((__le16 *)(&mac[4])) = cpu_to_le16(rcmta1);
printk(" MAC: %s", printk(" MAC: %pM", mac);
print_mac(macbuf, mac));
} else } else
printk(" DEFAULT KEY"); printk(" DEFAULT KEY");
printk("\n"); printk("\n");

10
drivers/net/wireless/libertas/assoc.c
View File

@ -129,7 +129,6 @@ static int lbs_set_authentication(struct lbs_private *priv, u8 bssid[6], u8 auth
{ {
struct cmd_ds_802_11_authenticate cmd; struct cmd_ds_802_11_authenticate cmd;
int ret = -1; int ret = -1;
DECLARE_MAC_BUF(mac);
lbs_deb_enter(LBS_DEB_JOIN); lbs_deb_enter(LBS_DEB_JOIN);
@ -138,8 +137,7 @@ static int lbs_set_authentication(struct lbs_private *priv, u8 bssid[6], u8 auth
cmd.authtype = iw_auth_to_ieee_auth(auth); cmd.authtype = iw_auth_to_ieee_auth(auth);
lbs_deb_join("AUTH_CMD: BSSID %s, auth 0x%x\n", lbs_deb_join("AUTH_CMD: BSSID %pM, auth 0x%x\n", bssid, cmd.authtype);
print_mac(mac, bssid), cmd.authtype);
ret = lbs_cmd_with_response(priv, CMD_802_11_AUTHENTICATE, &cmd); ret = lbs_cmd_with_response(priv, CMD_802_11_AUTHENTICATE, &cmd);
@ -342,8 +340,6 @@ static int lbs_associate(struct lbs_private *priv,
/* Firmware v9+ indicate authentication suites as a TLV */ /* Firmware v9+ indicate authentication suites as a TLV */
if (priv->fwrelease >= 0x09000000) { if (priv->fwrelease >= 0x09000000) {
DECLARE_MAC_BUF(mac);
auth = (struct mrvl_ie_auth_type *) pos; auth = (struct mrvl_ie_auth_type *) pos;
auth->header.type = cpu_to_le16(TLV_TYPE_AUTH_TYPE); auth->header.type = cpu_to_le16(TLV_TYPE_AUTH_TYPE);
auth->header.len = cpu_to_le16(2); auth->header.len = cpu_to_le16(2);
@ -351,8 +347,8 @@ static int lbs_associate(struct lbs_private *priv,
auth->auth = cpu_to_le16(tmpauth); auth->auth = cpu_to_le16(tmpauth);
pos += sizeof(auth->header) + 2; pos += sizeof(auth->header) + 2;
lbs_deb_join("AUTH_CMD: BSSID %s, auth 0x%x\n", lbs_deb_join("AUTH_CMD: BSSID %pM, auth 0x%x\n",
print_mac(mac, bss->bssid), priv->secinfo.auth_mode); bss->bssid, priv->secinfo.auth_mode);
} }
/* WPA/WPA2 IEs */ /* WPA/WPA2 IEs */

2
drivers/net/wireless/mac80211_hwsim.c
View File

@ -837,7 +837,6 @@ static void hwsim_send_ps_poll(void *dat, u8 *mac, struct ieee80211_vif *vif)
{ {
struct mac80211_hwsim_data *data = dat; struct mac80211_hwsim_data *data = dat;
struct hwsim_vif_priv *vp = (void *)vif->drv_priv; struct hwsim_vif_priv *vp = (void *)vif->drv_priv;
DECLARE_MAC_BUF(buf);
struct sk_buff *skb; struct sk_buff *skb;
struct ieee80211_pspoll *pspoll; struct ieee80211_pspoll *pspoll;
@ -867,7 +866,6 @@ static void hwsim_send_nullfunc(struct mac80211_hwsim_data *data, u8 *mac,
struct ieee80211_vif *vif, int ps) struct ieee80211_vif *vif, int ps)
{ {
struct hwsim_vif_priv *vp = (void *)vif->drv_priv; struct hwsim_vif_priv *vp = (void *)vif->drv_priv;
DECLARE_MAC_BUF(buf);
struct sk_buff *skb; struct sk_buff *skb;
struct ieee80211_hdr *hdr; struct ieee80211_hdr *hdr;

6
drivers/net/wireless/mwl8k.c
View File

@ -2271,7 +2271,6 @@ static int mwl8k_cmd_update_sta_db(struct ieee80211_hw *hw,
struct mwl8k_cmd_update_sta_db *cmd; struct mwl8k_cmd_update_sta_db *cmd;
struct peer_capability_info *peer_info; struct peer_capability_info *peer_info;
struct ieee80211_rate *bitrates = mv_vif->legacy_rates; struct ieee80211_rate *bitrates = mv_vif->legacy_rates;
DECLARE_MAC_BUF(mac);
int rc; int rc;
__u8 count, *rates; __u8 count, *rates;
@ -3480,7 +3479,6 @@ static int __devinit mwl8k_probe(struct pci_dev *pdev,
{ {
struct ieee80211_hw *hw; struct ieee80211_hw *hw;
struct mwl8k_priv *priv; struct mwl8k_priv *priv;
DECLARE_MAC_BUF(mac);
int rc; int rc;
int i; int i;
u8 *fw; u8 *fw;
@ -3669,8 +3667,8 @@ static int __devinit mwl8k_probe(struct pci_dev *pdev,
MWL8K_DESC); MWL8K_DESC);
printk(KERN_INFO "%s: Driver Ver:%s Firmware Ver:%u.%u.%u.%u\n", printk(KERN_INFO "%s: Driver Ver:%s Firmware Ver:%u.%u.%u.%u\n",
priv->name, MWL8K_VERSION, fw[3], fw[2], fw[1], fw[0]); priv->name, MWL8K_VERSION, fw[3], fw[2], fw[1], fw[0]);
printk(KERN_INFO "%s: MAC Address: %s\n", priv->name, printk(KERN_INFO "%s: MAC Address: %pM\n", priv->name,
print_mac(mac, hw->wiphy->perm_addr)); hw->wiphy->perm_addr);
return 0; return 0;

4
drivers/net/wireless/rt2x00/rt2800usb.c
View File

@ -2220,10 +2220,8 @@ static int rt2800usb_validate_eeprom(struct rt2x00_dev *rt2x00dev)
*/ */
mac = rt2x00_eeprom_addr(rt2x00dev, EEPROM_MAC_ADDR_0); mac = rt2x00_eeprom_addr(rt2x00dev, EEPROM_MAC_ADDR_0);
if (!is_valid_ether_addr(mac)) { if (!is_valid_ether_addr(mac)) {
DECLARE_MAC_BUF(macbuf);
random_ether_addr(mac); random_ether_addr(mac);
EEPROM(rt2x00dev, "MAC: %s\n", print_mac(macbuf, mac)); EEPROM(rt2x00dev, "MAC: %pM\n", mac);
} }
rt2x00_eeprom_read(rt2x00dev, EEPROM_ANTENNA, &word); rt2x00_eeprom_read(rt2x00dev, EEPROM_ANTENNA, &word);

5
drivers/net/wireless/wl12xx/wl1251_main.c
View File

@ -435,11 +435,10 @@ static int wl1251_op_add_interface(struct ieee80211_hw *hw,
struct ieee80211_if_init_conf *conf) struct ieee80211_if_init_conf *conf)
{ {
struct wl1251 *wl = hw->priv; struct wl1251 *wl = hw->priv;
DECLARE_MAC_BUF(mac);
int ret = 0; int ret = 0;
wl1251_debug(DEBUG_MAC80211, "mac80211 add interface type %d mac %s", wl1251_debug(DEBUG_MAC80211, "mac80211 add interface type %d mac %pM",
conf->type, print_mac(mac, conf->mac_addr)); conf->type, conf->mac_addr);
mutex_lock(&wl->mutex); mutex_lock(&wl->mutex);