redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

ACPI / APEI: Suppress message if HEST not present 

According to the ACPI specification, firmware is not required to provide
the Hardware Error Source Table (HEST). When HEST is not present, the
following superfluous message is printed to the kernel boot log -

[    3.460067] GHES: HEST is not enabled!

Extend hest_disable variable to track whether the firmware provides this
table and if it is not present skip any log output. The existing
behaviour is preserved in all other cases.

Suggested-by: Borislav Petkov <bp@suse.de>
Signed-off-by: Punit Agrawal <punit.agrawal@arm.com>
Reviewed-by: Borislav Petkov <bp@suse.de>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
hifive-unleashed-5.1
Punit Agrawal 2017-08-29 14:20:20 +01:00 committed by Rafael J. Wysocki
parent 1d5d820b8f
commit e931d0dab4
3 changed files with 20 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/acpi/apei/ghes.c
View File

@ -1266,9 +1266,14 @@ static int __init ghes_init(void)
if (acpi_disabled)
return -ENODEV;
if (hest_disable) {
switch (hest_disable) {
case HEST_NOT_FOUND:
return -ENODEV;
case HEST_DISABLED:
pr_info(GHES_PFX "HEST is not enabled!\n");
return -EINVAL;
default:
break;
}
if (ghes_disable) {

13
drivers/acpi/apei/hest.c
View File

@ -37,7 +37,7 @@
#define HEST_PFX "HEST: "
bool hest_disable;
int hest_disable;
EXPORT_SYMBOL_GPL(hest_disable);
/* HEST table parsing */
@ -213,7 +213,7 @@ err:
static int __init setup_hest_disable(char *str)
{
hest_disable = 1;
hest_disable = HEST_DISABLED;
return 0;
}
@ -232,9 +232,10 @@ void __init acpi_hest_init(void)
status = acpi_get_table(ACPI_SIG_HEST, 0,
(struct acpi_table_header **)&hest_tab);
if (status == AE_NOT_FOUND)
goto err;
else if (ACPI_FAILURE(status)) {
if (status == AE_NOT_FOUND) {
hest_disable = HEST_NOT_FOUND;
return;
} else if (ACPI_FAILURE(status)) {
const char *msg = acpi_format_exception(status);
pr_err(HEST_PFX "Failed to get table, %s\n", msg);
rc = -EINVAL;
@ -257,5 +258,5 @@ void __init acpi_hest_init(void)
pr_info(HEST_PFX "Table parsing has been initialized.\n");
return;
err:
hest_disable = 1;
hest_disable = HEST_DISABLED;
}

8
include/acpi/apei.h
View File

@ -16,7 +16,13 @@
#ifdef __KERNEL__
extern bool hest_disable;
enum hest_status {
HEST_ENABLED,
HEST_DISABLED,
HEST_NOT_FOUND,
};
extern int hest_disable;
extern int erst_disable;
#ifdef CONFIG_ACPI_APEI_GHES
extern bool ghes_disable;