redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

checkkconfigsymbols.py: fix sorted output 

Commit b1a3f24348 ("checkkconfigsymbols.py: make it Git aware")
mistakenly removed to print undefined Kconfig symbols in alphabetical
order.  Furthermore, the script does not print anything anymore when the
entire tree is checked (i.e., when no commit is specified).

This patch restores the sorted output and adds the missing print for the
default case.  Additionally, the file lists are now sorted as well which
(a) makes it easier to read and (b) makes the output deterministic.

Signed-off-by: Valentin Rothberg <valentinrothberg@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
hifive-unleashed-5.1
Valentin Rothberg 2015-03-23 18:40:49 +01:00 committed by Greg Kroah-Hartman
parent a087146c72
commit e9533ae539
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
scripts/checkkconfigsymbols.py
View File

@ -112,14 +112,15 @@ def main():
undefined_b = check_symbols()
# report cases that are present for the commit but not before
for feature in undefined_b:
for feature in sorted(undefined_b):
# feature has not been undefined before
if not feature in undefined_a:
files = undefined_b.get(feature)
files = sorted(undefined_b.get(feature))
print "%s\t%s" % (feature, ", ".join(files))
# check if there are new files that reference the undefined feature
else:
files = undefined_b.get(feature) - undefined_a.get(feature)
files = sorted(undefined_b.get(feature) -
undefined_a.get(feature))
if files:
print "%s\t%s" % (feature, ", ".join(files))
@ -129,8 +130,9 @@ def main():
# default to check the entire tree
else:
undefined = check_symbols()
for feature in undefined:
files = undefined.get(feature)
for feature in sorted(undefined):
files = sorted(undefined.get(feature))
print "%s\t%s" % (feature, ", ".join(files))
def execute(cmd):