redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

staging: dgap: fix returned errno code in dgap_parsefile()

Browse source 
The driver is using -1 instead of the -ENOMEM defined macro to specify
that a buffer allocation failed. Since the error number is propagated,
the caller will get a -EPERM which is the wrong error condition.

Also, the smatch tool complains with the following warning:

dgap_parsefile() warn: returning -1 instead of -ENOMEM is sloppy

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Javier Martinez Canillas 2015-09-22 02:39:36 +02:00 committed by Greg Kroah-Hartman
parent 3f937918b7
commit e98631d83c
1 changed files with 16 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

32
drivers/staging/dgap/dgap.c
View file

@ -642,7 +642,7 @@ static int dgap_parsefile(char **in)
p->next = kzalloc(sizeof(struct cnode), GFP_KERNEL);
if (!p->next)
return -1;
return -ENOMEM;
p = p->next;
@ -861,7 +861,7 @@ static int dgap_parsefile(char **in)
p->next = kzalloc(sizeof(struct cnode), GFP_KERNEL);
if (!p->next)
return -1;
return -ENOMEM;
p = p->next;
p->type = TNODE;
@ -883,7 +883,7 @@ static int dgap_parsefile(char **in)
p->next = kzalloc(sizeof(struct cnode), GFP_KERNEL);
if (!p->next)
return -1;
return -ENOMEM;
p = p->next;
p->type = CUNODE;
@ -914,7 +914,7 @@ static int dgap_parsefile(char **in)
p->next = kzalloc(sizeof(struct cnode), GFP_KERNEL);
if (!p->next)
return -1;
return -ENOMEM;
p = p->next;
p->type = LNODE;
@ -933,7 +933,7 @@ static int dgap_parsefile(char **in)
p->next = kzalloc(sizeof(struct cnode), GFP_KERNEL);
if (!p->next)
return -1;
return -ENOMEM;
p = p->next;
p->type = CNODE;
@ -975,7 +975,7 @@ static int dgap_parsefile(char **in)
p->next = kzalloc(sizeof(struct cnode), GFP_KERNEL);
if (!p->next)
return -1;
return -ENOMEM;
p = p->next;
p->type = MNODE;
@ -1054,7 +1054,7 @@ static int dgap_parsefile(char **in)
p->next = kzalloc(sizeof(struct cnode), GFP_KERNEL);
if (!p->next)
return -1;
return -ENOMEM;
p = p->next;
p->type = PNODE;
@ -1076,7 +1076,7 @@ static int dgap_parsefile(char **in)
p->next = kzalloc(sizeof(struct cnode), GFP_KERNEL);
if (!p->next)
return -1;
return -ENOMEM;
p = p->next;
p->type = JNODE;
@ -1098,7 +1098,7 @@ static int dgap_parsefile(char **in)
p->next = kzalloc(sizeof(struct cnode), GFP_KERNEL);
if (!p->next)
return -1;
return -ENOMEM;
p = p->next;
p->type = ANODE;
@ -1120,7 +1120,7 @@ static int dgap_parsefile(char **in)
p->next = kzalloc(sizeof(struct cnode), GFP_KERNEL);
if (!p->next)
return -1;
return -ENOMEM;
p = p->next;
p->type = INTRNODE;
@ -1141,7 +1141,7 @@ static int dgap_parsefile(char **in)
p->next = kzalloc(sizeof(struct cnode), GFP_KERNEL);
if (!p->next)
return -1;
return -ENOMEM;
p = p->next;
p->type = TSNODE;
@ -1163,7 +1163,7 @@ static int dgap_parsefile(char **in)
p->next = kzalloc(sizeof(struct cnode), GFP_KERNEL);
if (!p->next)
return -1;
return -ENOMEM;
p = p->next;
p->type = CSNODE;
@ -1185,7 +1185,7 @@ static int dgap_parsefile(char **in)
p->next = kzalloc(sizeof(struct cnode), GFP_KERNEL);
if (!p->next)
return -1;
return -ENOMEM;
p = p->next;
p->type = BSNODE;
@ -1207,7 +1207,7 @@ static int dgap_parsefile(char **in)
p->next = kzalloc(sizeof(struct cnode), GFP_KERNEL);
if (!p->next)
return -1;
return -ENOMEM;
p = p->next;
p->type = USNODE;
@ -1229,7 +1229,7 @@ static int dgap_parsefile(char **in)
p->next = kzalloc(sizeof(struct cnode), GFP_KERNEL);
if (!p->next)
return -1;
return -ENOMEM;
p = p->next;
p->type = FSNODE;
@ -1251,7 +1251,7 @@ static int dgap_parsefile(char **in)
p->next = kzalloc(sizeof(struct cnode), GFP_KERNEL);
if (!p->next)
return -1;
return -ENOMEM;
p = p->next;
p->type = VSNODE;