[media] media/rc/imon.c: avoid flooding syslog with "unknown keypress" when keypad is pressed
My 15c2:0036 device floods syslog when a keypad key is pressed: Feb 18 19:00:57 homeserver kernel: imon 5-1:1.0: imon_incoming_packet: unknown keypress, code 0x100fff2 Feb 18 19:00:57 homeserver kernel: imon 5-1:1.0: imon_incoming_packet: unknown keypress, code 0x100fef2 Feb 18 19:00:57 homeserver kernel: imon 5-1:1.0: imon_incoming_packet: unknown keypress, code 0x100fff2 Feb 18 19:00:57 homeserver kernel: imon 5-1:1.0: imon_incoming_packet: unknown keypress, code 0x100fff2 Feb 18 19:00:57 homeserver kernel: imon 5-1:1.0: imon_incoming_packet: unknown keypress, code 0x100fff2 This patch removes those messages from imon, following suggestion from Mauro. Unknown keys shall be correctly handled by rc/input layer. Signed-off-by: Kevin Baradon <kevin.baradon@gmail.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
parent
26ccbec44a
commit
e9e7a16d6d
|
@ -1573,11 +1573,6 @@ static void imon_incoming_packet(struct imon_context *ictx,
|
||||||
if (press_type < 0)
|
if (press_type < 0)
|
||||||
goto not_input_data;
|
goto not_input_data;
|
||||||
|
|
||||||
spin_lock_irqsave(&ictx->kc_lock, flags);
|
|
||||||
if (ictx->kc == KEY_UNKNOWN)
|
|
||||||
goto unknown_key;
|
|
||||||
spin_unlock_irqrestore(&ictx->kc_lock, flags);
|
|
||||||
|
|
||||||
if (ktype != IMON_KEY_PANEL) {
|
if (ktype != IMON_KEY_PANEL) {
|
||||||
if (press_type == 0)
|
if (press_type == 0)
|
||||||
rc_keyup(ictx->rdev);
|
rc_keyup(ictx->rdev);
|
||||||
|
@ -1620,12 +1615,6 @@ static void imon_incoming_packet(struct imon_context *ictx,
|
||||||
|
|
||||||
return;
|
return;
|
||||||
|
|
||||||
unknown_key:
|
|
||||||
spin_unlock_irqrestore(&ictx->kc_lock, flags);
|
|
||||||
dev_info(dev, "%s: unknown keypress, code 0x%llx\n", __func__,
|
|
||||||
(long long)scancode);
|
|
||||||
return;
|
|
||||||
|
|
||||||
not_input_data:
|
not_input_data:
|
||||||
if (len != 8) {
|
if (len != 8) {
|
||||||
dev_warn(dev, "imon %s: invalid incoming packet "
|
dev_warn(dev, "imon %s: invalid incoming packet "
|
||||||
|
|
Loading…
Reference in a new issue